1173907 - GTK3: Progress bars have strange tick

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Andrew Comminos [:acomminos]]

Attachment: Progress bar on GTK3 firefox

On GTK3, progress bars are drawn with a strange tick. This appears to be caused by a call to gtk_render_activity when drawing a progress chunk.

Comment 1

[Andrew Comminos [:acomminos]]

Martin, Karl; do you seem to know why we make a call to gtk_render_activity in moz_gtk_progress_chunk_paint for all types of progress bars? It seems to be intended for activity indicators, not progress bars.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Downstream Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=1226657

Comment 3

[Karl Tomlinson (:karlt)]

(In reply to Andrew Comminos [:acomminos] from comment #1)
> Martin, Karl; do you seem to know why we make a call to gtk_render_activity
> in moz_gtk_progress_chunk_paint for all types of progress bars? It seems to
> be intended for activity indicators, not progress bars.

I wonder whether you are asking about the same issue I pointed out in https://bugzilla.mozilla.org/show_bug.cgi?id=634086#c7

"indeterminate" progress bars show activity even when there is no activity.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Sorry I have no idea.

Comment 5

[Andrew Comminos [:acomminos]]

Attachment: Remove indeterminate progress indicators on progress chunks with GTK3.

Since it doesn't look like the activity indicator has any purpose in drawing a progress chunk, this patch just simply removes it.

Comment 6

[Karl Tomlinson (:karlt)]

Comment on attachment 8626216 [details] [diff] [review]
Remove indeterminate progress indicators on progress chunks with GTK3.

This seems to be another gtk+ 3.14 theming api change.

gtk_progress_bar_paint_activity and gtk_progress_bar_paint_continuous used
gtk_render_activity prior to 3.14 and now use gtk_render_background and
gtk_render_frame.

Given we hope to support pre-3.14 versions, I don't think we should remove
support for those versions, and so version detection is probably required for
api detection.

Comment 7

[Andrew Comminos [:acomminos]]

Attachment: Don't use gtk_render_activity for drawing progress chunks on GTK versions above 3.13.7.

Thanks, looks like the change was made earliest in 3.13.7 with GTK commit 6c06bd55dae61ce6066555c7d4794ed9ca3911de.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing on top of inbound tip.

Comment 9

[Andrew Comminos [:acomminos]]

Attachment: Don't use gtk_render_activity for drawing progress chunks on GTK versions above 3.13.7. Carry r=karlt

Rebased, thanks.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a14fde78ca7

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a14fde78ca7